[feature request]Rename UnitedDeployment to YurtAppSet

[rambohe-ch]

What would you like to be added:
Rename UnitedDeployment to YurtAppSet.

Why is this needed:
From discussion from this issue: #433, UnitedDeployment should be renamed as YurtAppSet.

others
/kind feature

[moyuduo]

Hello, i am a new comer of openyurt project, i have been watching this project for months, now i want to resolve this simple issue to learn openyurt project gradually and becoming a contributor of openyurt project, is this ok?

[rambohe-ch]

Hello, i am a new comer of openyurt project, i have been watching this project for months, now i want to resolve this simple issue to learn openyurt project gradually and becoming a contributor of openyurt project, is this ok?

@moyuduo welcome you to contribute to OpenYurt. if you need to any help, please me know in any way.
/assign @moyuduo

[moyuduo]

Hello, i am a new comer of openyurt project, i have been watching this project for months, now i want to resolve this simple issue to learn openyurt project gradually and becoming a contributor of openyurt project, is this ok?

@moyuduo welcome you to contribute to OpenYurt. if you need to any help, please me know in any way. /assign @moyuduo

I note that yurt-app-manager has alerdy remove from openyurt into yurt-app-manager repo, should i fork the latter and create pull request to this repo?

[rambohe-ch]

Hello, i am a new comer of openyurt project, i have been watching this project for months, now i want to resolve this simple issue to learn openyurt project gradually and becoming a contributor of openyurt project, is this ok?

@moyuduo welcome you to contribute to OpenYurt. if you need to any help, please me know in any way. /assign @moyuduo

I note that yurt-app-manager has alerdy remove from openyurt into yurt-app-manager repo, should i fork the latter and create pull request to this repo?

@moyuduo sorry to feedback late, please make a rename pull request in openyurtio/yurt-app-manager repo.

[rambohe-ch]

@zzguang @kadisi how about make a pull request of renaming UnitedDeployment to YurtAppSet in openyurtio/yurt-app-manager repo?

[moyuduo]

Hello, i am a new comer of openyurt project, i have been watching this project for months, now i want to resolve this simple issue to learn openyurt project gradually and becoming a contributor of openyurt project, is this ok?

@moyuduo welcome you to contribute to OpenYurt. if you need to any help, please me know in any way. /assign @moyuduo

I note that yurt-app-manager has alerdy remove from openyurt into yurt-app-manager repo, should i fork the latter and create pull request to this repo?

@moyuduo sorry to feedback late, please make a rename pull request in openyurtio/yurt-app-manager repo.

ok, i have some question that i forked yurt-app-manager to my own namespace and i forget to resync the latest code, when i realize that i have alerdy finish rename, so now the git flow as follow.

[root@centos72 yurt-app-manager]# git log --graph --oneline
*   ca18d81 (HEAD -> feature/rename_uniteddeployment_to_yurtappset) Merge branch 'master' into feature/rename_uniteddeployment_to_yurtappset
|\  
| * 5dc7d07 (origin/master, origin/HEAD, master) ingress: add nodepool edge node taints tolerations (#38)
| * 4eb0982 ingress: update yurtingress tutorial link (#37)
| * 2288a2e add 0.5.0 relase and all_in_one yaml (#35)
| * 3fa127c update README to add YurtAppDaemon and YurtIngress (#34)
| * aa6e57b ingress: fix YurtIngress CR status update error (#33)
| * 82f3c34 Initialize capabilities to support enabling containers[*].securityContext.privileged for UnitedDeployment (#26)
| * 457ddb5 Add YurtIngress operator implementation (#32)
| * 783b1be use https[s] proxy in docker for release build if necessary (#28)
| * 9046f0f hotfix: Lables fix to Annotations (#29)
| * 613e42d yurt-app-manager support YurtAppDaemon CRD (#27)
* | 8384768 feature: rename UnitedDeployment to YurtAppSet
|/  
* ab2a014 Fix yurt-app-manager deployment fail due to nodeSelector and tolerance mismatch (#25)

i note that openyurt require single commit each pr, so how can i rebase 8384768 and ca18d81 into one commit

[zzguang]

@zzguang @kadisi how about make a pull request of renaming UnitedDeployment to YurtAppSet in openyurtio/yurt-app-manager repo?

Sure, welcome for the contribution about it.

[zzguang]

Hello, i am a new comer of openyurt project, i have been watching this project for months, now i want to resolve this simple issue to learn openyurt project gradually and becoming a contributor of openyurt project, is this ok?

@moyuduo welcome you to contribute to OpenYurt. if you need to any help, please me know in any way. /assign @moyuduo

I note that yurt-app-manager has alerdy remove from openyurt into yurt-app-manager repo, should i fork the latter and create pull request to this repo?

@moyuduo sorry to feedback late, please make a rename pull request in openyurtio/yurt-app-manager repo.

ok, i have some question that i forked yurt-app-manager to my own namespace and i forget to resync the latest code, when i realize that i have alerdy finish rename, so now the git flow as follow.

[root@centos72 yurt-app-manager]# git log --graph --oneline
*   ca18d81 (HEAD -> feature/rename_uniteddeployment_to_yurtappset) Merge branch 'master' into feature/rename_uniteddeployment_to_yurtappset
|\  
| * 5dc7d07 (origin/master, origin/HEAD, master) ingress: add nodepool edge node taints tolerations (#38)
| * 4eb0982 ingress: update yurtingress tutorial link (#37)
| * 2288a2e add 0.5.0 relase and all_in_one yaml (#35)
| * 3fa127c update README to add YurtAppDaemon and YurtIngress (#34)
| * aa6e57b ingress: fix YurtIngress CR status update error (#33)
| * 82f3c34 Initialize capabilities to support enabling containers[*].securityContext.privileged for UnitedDeployment (#26)
| * 457ddb5 Add YurtIngress operator implementation (#32)
| * 783b1be use https[s] proxy in docker for release build if necessary (#28)
| * 9046f0f hotfix: Lables fix to Annotations (#29)
| * 613e42d yurt-app-manager support YurtAppDaemon CRD (#27)
* | 8384768 feature: rename UnitedDeployment to YurtAppSet
|/  
* ab2a014 Fix yurt-app-manager deployment fail due to nodeSelector and tolerance mismatch (#25)

i note that openyurt require single commit each pr, so how can i rebase 8384768 and ca18d81 into one commit

@moyuduo , welcome for your contribution to yurt-app-manager, some suggestions about your question:

1. Your PR should base on the latest upstream source code, which aims to avoid the code conflict for merging. So you need firstly pull the latest source code then add your commit "8384768" basing on it, if any code conflict, you need to fix it.
2. One PR can contain one or several commits, so after you add commit "8384768", you can add commit "ca18d81" base on it, then submit a PR including both of them. Also you can merge commit "8384768" and "ca18d81" into one then submit a PR including the merged commit.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[xavier-hou]

Is anyone working on this issue right now? If no one is, I want to take it.

[rambohe-ch]

/assign @HXCGIT

[rambohe-ch]

Is anyone working on this issue right now? If no one is, I want to take it.

@HXCGIT This issue is still idle, welcome you to take it.

[xavier-hou]

@rambohe-ch Currently I think three repos (openyurt, yurt-app-manager and openyurt.io) need to make relevant changes, right?

[rambohe-ch]

@rambohe-ch Currently I think three repos (openyurt, yurt-app-manager and openyurt.io) need to make relevant changes, right?

@HXCGIT yes, please post your pull requests.