Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REGRESSION] Collapsing of section don't work fine anymore #952

Closed
kelson42 opened this issue Aug 25, 2019 · 10 comments · Fixed by #959
Closed

[REGRESSION] Collapsing of section don't work fine anymore #952

kelson42 opened this issue Aug 25, 2019 · 10 comments · Fixed by #959
Assignees

Comments

@kelson42
Copy link
Collaborator

See http://library.kiwix.org/wikipedia_en_geography_maxi/A/England.

Collapsing "Toponymy" does not hide subsection "Prehistory and antiquity". It should also "hide" all the subsection (but not collapse then). It does not.

@Jaifroid
Copy link
Collaborator

We've been discussing this wrt a workaround that I proposed in Kiwix JS for opening all details sections. @mossroy is of the opinion, and I agree, that it would be best to get this right in mwoffliner, as it's not quite working as intended. I made a related report in #838 (comment). To summarize, we have some inconsistency with the way the open attribute is added to the <details> tags: it's added at lower heading levels (h3, h4) but not at higher levels (h2). There's probably a similar underlying cause as for this issue. I'd be happy to take a look at the code if @ISNIT0 can guide me as to where the details-summary tags are added.

@ISNIT0
Copy link
Contributor

ISNIT0 commented Aug 29, 2019

@Jaifroid This ticket represents a bug, which will hopefully be fixed soon - the other issues should probably be discussed on the other ticket.

@kelson42
Copy link
Collaborator Author

kelson42 commented Oct 4, 2019

@ISNIT0 This is still not working fine! with WPTL article Guam, here is what I get on my phone!
Screenshot_20191004-094610

Not only the sections are expanded where they should not but the arrows do not stick anymore to the title!

@kelson42 kelson42 reopened this Oct 4, 2019
@kelson42
Copy link
Collaborator Author

kelson42 commented Oct 4, 2019

We have also a double horizontal lines appearing!

@ISNIT0
Copy link
Contributor

ISNIT0 commented Oct 4, 2019

@kelson42 This looks like a different issue to what's reported?

@kelson42
Copy link
Collaborator Author

kelson42 commented Oct 4, 2019

@ISNIT0 Might be... But I'm out of patience and don't have the time to go through all the multiple tickets I have been opening in the last 6 months about this really specific small feature to know which is the best match.

@ISNIT0
Copy link
Contributor

ISNIT0 commented Oct 15, 2019

I don't see the same thing when I scrape with master.
image

Possible it was an API/WikiText issue?

@kelson42
Copy link
Collaborator Author

kelson42 commented Oct 19, 2019

@ISNIT0 This is easy to verify. What are the HTML differences?

@stale
Copy link

stale bot commented Dec 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Dec 18, 2019
@kelson42
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants