From 9d63c3401ff449b4a25441592f2aae2cf7bba596 Mon Sep 17 00:00:00 2001 From: Henriette Darge Date: Wed, 9 Aug 2023 13:14:00 +0200 Subject: [PATCH] Rename gem and update some docs --- .github/pull_request_template.md | 2 -- .github/release_template.md | 10 +++++----- Gemfile.lock | 2 +- demo/Gemfile | 2 +- demo/Gemfile.lock | 2 +- primer_view_components.gemspec | 2 +- 6 files changed, 9 insertions(+), 11 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ac231eb126..f637dc85bb 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -54,5 +54,3 @@ Closes # (type the GitHub issue number after #) - [ ] Tested in Firefox - [ ] Tested in Safari - [ ] Tested in Edge - -Take a look at the [What we look for in reviews](https://github.com/primer/react/blob/main/contributor-docs/CONTRIBUTING.md#what-we-look-for-in-reviews) section of the contributing guidelines for more information on how we review PRs. diff --git a/.github/release_template.md b/.github/release_template.md index 20cb8d05c9..71d5806f28 100644 --- a/.github/release_template.md +++ b/.github/release_template.md @@ -5,19 +5,19 @@ Please ensure these items are checked before merging. ### 🔎 Smoke test - [ ] All CI checks pass -- [ ] Docs and Lookbook open in a browser -- [ ] Successful integration test with GitHub.com as a primary consumer of Primer View Components - - [ ] Install the npm release candidate in `npm-workspaces/primer/` - - [ ] Use `bin/vendor-gem` to update `primer_view_components` gem +- [ ] Successful integration test with OpenProject as a primary consumer + - [ ] Install the npm package locally + - [ ] Install the `primer_view_components` gem locally - [ ] Verify no new build errors appear - [ ] Verify no new linting errors appear - [ ] Manually test critical paths - [ ] Manually test release-specific bugfixes and/or features work as described + - [ ] Lookbook opens in a browser ### 🤔 Sanity test - [ ] All bugfixes in this release have resolved their corresponding issues -- [ ] All new features in this release have been tested and verified as compatible with GitHub.com +- [ ] All new features in this release have been tested and verified as compatible with OpenProject - [ ] No noticeable regressions have been introduced as a result of changes in this release - [ ] Release notes accurately describe the changes made diff --git a/Gemfile.lock b/Gemfile.lock index e1f3fc484c..c2f4048f9f 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -253,7 +253,7 @@ DEPENDENCIES matrix (~> 0.4.2) minitest (< 5.19) mocha - openproject_primer_view_components! + openproject-primer_view_components! pry puma (~> 6.3.0) rack (~> 2.2) diff --git a/demo/Gemfile b/demo/Gemfile index 4eef4d7a4e..9b357e7643 100644 --- a/demo/Gemfile +++ b/demo/Gemfile @@ -36,7 +36,7 @@ gem "puma", "~> 6.3.0" # Reduces boot times through caching; required in config/boot.rb gem "bootsnap", ">= 1.4.2", require: false -gem "openproject_primer_view_components", path: "../" +gem "openproject-primer_view_components", path: "../" gem "view_component", '>= 3.1.0' gem "lookbook", "~> 2.0.5" unless rails_version.to_f < 7 diff --git a/demo/Gemfile.lock b/demo/Gemfile.lock index 7463663eef..8797a1d55e 100644 --- a/demo/Gemfile.lock +++ b/demo/Gemfile.lock @@ -392,7 +392,7 @@ DEPENDENCIES kuby-kind (~> 0.1) listen lookbook (~> 2.0.5) - openproject_primer_view_components! + openproject-primer_view_components! pry-byebug puma (~> 6.3.0) rack-cors diff --git a/primer_view_components.gemspec b/primer_view_components.gemspec index 34707b4af8..451e986641 100644 --- a/primer_view_components.gemspec +++ b/primer_view_components.gemspec @@ -5,7 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) require "primer/view_components/version" Gem::Specification.new do |spec| - spec.name = "openproject_primer_view_components" + spec.name = "openproject-primer_view_components" spec.version = Primer::ViewComponents::VERSION::STRING spec.authors = ["GitHub Open Source", "OpenProject GmbH"]