fixed the problem when you could change the volume while muted #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If want to prevent the user from being able to change the volume while muted (should we that's a discussion for the issue section)? The purpose of the loop in line 173 is to keep handling tags until we reach a tag which hasn't started yet, only then we go to sleep. Either way the change to the loop should have been raised as a separate issue and discussed :-) |
|
That is the main reason i wanted you or eyal to review this, i am not sure the loop is doing its purpose, i will check, and if it isn't i will make this an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please note that i removed(commented out) the while loop on line 173, that while loop wasnt really looping, it was running once and then stopped. changed it to a if condition, which will loop because we are inside an infinite loop.
i think ophir or eyal really needs to see this one for approval.