Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add name and remove language from LanguageTag #296

Closed
Tracked by #290
samuelstroschein opened this issue Jan 21, 2023 · 0 comments
Closed
Tracked by #290

add name and remove language from LanguageTag #296

samuelstroschein opened this issue Jan 21, 2023 · 0 comments
Assignees
Labels
scope: inlang/sdk Related to source-code/sdk. type: refactor Code being refactored to improved performance or long-term maintainability.

Comments

@samuelstroschein
Copy link
Member

Problem

The LanguageTag AST contains language property which is supposed to be an ISO-639 identifier but that is not validated. Enforcing ISO-639 ids prevents projects to adopt inlang when they already use country code mixes like en-US.

Proposal

Remove the language property and add name.

name can be an arbitrary identifier and will be deprecated when language tags are fully supported. That opens the possibility to support language-country identifiers now without implementing constant string-based conditional logic.

@samuelstroschein samuelstroschein added type: refactor Code being refactored to improved performance or long-term maintainability. scope: inlang/sdk Related to source-code/sdk. labels Jan 21, 2023
@samuelstroschein samuelstroschein self-assigned this Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: inlang/sdk Related to source-code/sdk. type: refactor Code being refactored to improved performance or long-term maintainability.
Projects
None yet
Development

No branches or pull requests

1 participant