fix annotation regression #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
vladak
changed the title
- if no document, fallback to repository check - reuse repository object where possible - refactor annotation cache creation into method - use common xref-able check in UI and indexer
vladak
changed the title
some of the repositories can be enabled based on the environment
ginoaugustine
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restores the ability to get annotations for xref-able files in the UI. The way it works with this change is that if there is a document for given file, it is used for negative check, i.e. if there is no type in the document or the type is not xref-able, the file is considered not eligible for annotation. If no document can be found for the file, the repository will be checked. This way, with some refactoring, it should work for both the UI and the indexer (when annotation cache is created). Using the "xrefable" property as "annotatable" property (not considering the missing document caveat) is not entirely correct, however it is better to leave this for a subsequent PR; the focus of this PR should be the regression fix.