Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove helix-p4d from install list #4520

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Remove helix-p4d from install list #4520

merged 2 commits into from
Jan 5, 2024

Conversation

parheliamm
Copy link
Contributor

helix-p4d didn't available on ARM64 platform,
there is no obvious impacts after checking docker image on ARM64

After this change, docker image created successfully on ARM64 platform.

@oracle-contributor-agreement Oracle Contributor Agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Dec 25, 2023
vladak
vladak requested changes Dec 25, 2023
View reviewed changes
Copy link
Member

@vladak vladak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will remove Perforce from x86 image, though. Is there a way how to make it optional ?

@parheliamm parheliamm force-pushed the master branch 2 times, most recently from fdb7577 to 5c81501 Compare December 26, 2023 04:11
@parheliamm
Copy link
Contributor Author

This will remove Perforce from x86 image, though. Is there a way how to make it optional ?

The new patches detect the architecture during docker image build stage.
If ARM64 found, skip install helix-p4d only.

@vladak
Copy link
Member

vladak commented Dec 26, 2023

Ack, need to have your OCA on file before this can go in.

@parheliamm
Copy link
Contributor Author

Ack, need to have your OCA on file before this can go in.

OCA is under reviewing, it might be passed in coming days.

@oracle-contributor-agreement Oracle Contributor Agreement
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Jan 2, 2024
@vladak
Copy link
Member

vladak commented Jan 2, 2024

Seems like the Docker image linter complains about the multiple RUNs. The error can be suppressed.

@parheliamm
Copy link
Contributor Author

Seems like the Docker image linter complains about the multiple RUNs. The error can be suppressed.

Do I need to check the the failure issue and fix it?

@vladak
Copy link
Member

vladak commented Jan 3, 2024

Seems like the Docker image linter complains about the multiple RUNs. The error can be suppressed.

Do I need to check the the failure issue and fix it?

yes, the build has to be clean for this to get in.

@parheliamm
Ingore helix-p4d on ARM64
5be3ce9 
helix-p4d didn't available on ARM64 platform,
there is no obvious impacts after removing it on ARM64.

Signed-off-by: Chenxi Mao <[email protected]>
vladak
vladak reviewed Jan 5, 2024
View reviewed changes
@vladak vladak merged commit d768007 into oracle:master Jan 5, 2024
9 checks passed
@vladak
Copy link
Member

vladak commented Jan 5, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladak vladak vladak requested changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parheliamm @vladak