Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass output file path instead of file object #4525

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

vladak
Copy link
Member

@vladak vladak commented Jan 8, 2024

This change should fix the regression with config file merging in Docker.

Currently I am not able to test locally because of 404 errors on security.ubuntu.com while building the image.

@vladak vladak added the docker label Jan 8, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 8, 2024
@MasterAwesome
Copy link

The change works for me.

@vladak vladak merged commit 2568862 into oracle:master Jan 9, 2024
9 checks passed
@vladak vladak deleted the docker_config_merge_path branch January 9, 2024 09:03
@vladak
Copy link
Member Author

vladak commented Jan 9, 2024

Reconfirmed (building the Docker image passes once again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants