Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github.com/moby/term to golang.org/x/term #908

Closed
1 task
shizhMSFT opened this issue Mar 28, 2023 · 1 comment · Fixed by #910
Closed
1 task

Update github.com/moby/term to golang.org/x/term #908

shizhMSFT opened this issue Mar 28, 2023 · 1 comment · Fixed by #910
Assignees
@qweeah
Labels
enhancement New feature or request
Milestone
v1.1.0

Comments

@shizhMSFT
Copy link
Contributor

What is the version of your ORAS CLI

v1.0.0

What would you like to be added?

Update github.com/moby/term to golang.org/x/term

Why is this needed for ORAS?

oras uses untagged version of github.com/moby/term for reading passwords in oras login since the package term does not have any tags.

oras/go.mod

Line 7 in 67dca8e

github.com/moby/term v0.0.0-20210619224110-3f7ff695adc6

By updating to golang.org/x/term, we can also remove the dependencies on

oras/go.mod

Line 19 in 67dca8e

github.com/Azure/go-ansiterm v0.0.0-20210617225240-d185dfc1b5a1 // indirect

and

oras/go.mod

Line 25 in 67dca8e

golang.org/x/sys v0.0.0-20220715151400-c0bba94af5f8 // indirect

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@shizhMSFT shizhMSFT added the enhancement New feature or request label Mar 28, 2023
@shizhMSFT shizhMSFT added this to the v1.1.0 milestone Mar 28, 2023
@qweeah
Copy link
Contributor

qweeah commented Mar 29, 2023

I can work on this. Just refactoring oras login code to make E2E cover manual input scenario.

@qweeah qweeah self-assigned this Mar 29, 2023
@qweeah qweeah mentioned this issue Mar 29, 2023
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in ORAS Project Board-2023 Apr 10, 2023
This was referenced Jul 5, 2023
Closed
Merged
@qweeah qweeah mentioned this issue Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qweeah qweeah

Labels
enhancement New feature or request
Projects
ORAS Project Board-2023
Status: Done
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

refactor: replace terminal package used by oras login qweeah/oras
2 participants
@qweeah @shizhMSFT