Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

React PDF Improvements #1

Closed
tpreusse opened this issue Dec 14, 2017 · 3 comments
Closed

React PDF Improvements #1

tpreusse opened this issue Dec 14, 2017 · 3 comments

Comments

@tpreusse
Copy link
Contributor

tpreusse commented Dec 14, 2017

In general, our basic requirements are supported, but not all desired features are available yet.

Page Breaks

Page breaks work in general, but we need to invest work to measure element heights and break into a new page when needed.

Misc

@diegomura
Copy link
Contributor

Page break is working fine now right? Do we still need that measurement function. I truly don't know if that would be possible (react-pdf first calculates the layout, and then renders) and don't see the benefit to be honest

@tpreusse
Copy link
Contributor Author

tpreusse commented Feb 7, 2018

@diegomura I think it's fine for now—updated the issue. Let's verify with design and the final layout later on.

@diegomura
Copy link
Contributor

I created an issue for each remaining point of the list. I'm going to close this issue in favor of the other ones

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants