Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression #1166

Closed
casey opened this issue Jan 5, 2023 · 2 comments · Fixed by #1172
Closed

Performance regression #1166

casey opened this issue Jan 5, 2023 · 2 comments · Fixed by #1172
Milestone

Comments

@casey
Copy link
Collaborator

casey commented Jan 5, 2023

I triggered a database rebuild on ordinals.com last night, using commit 1ad94af. It should have been done by now, but it's still at block height ~265000. Indexing is slow enough that I suspect it might not finish, or take an enormously long time.

The last deployed version was 0.3.0, and looking through the commit history since then, there have been a few suspicious commits:

@casey casey added this to the Mainnet milestone Jan 5, 2023
@casey
Copy link
Collaborator Author

casey commented Jan 5, 2023

I'm rebuilding the database with redb 0.10.0, to narrow it down to either an issue with redb, or an issue with one of our changes. #1167

@casey
Copy link
Collaborator Author

casey commented Jan 5, 2023

Not done yet, but it looks like it's still slow with redb 0.10.0. I'm thinking that it's the other two PRs. In particular, they added writes mid-update, instead of only flushing at the end of the update.

If it's definitely not redb, then I should modify the updater to only flush at the end of each update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant