Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-existant output lookups return 500 error #3919

Closed
casey opened this issue Aug 29, 2024 · 2 comments · Fixed by #3968
Closed

Non-existant output lookups return 500 error #3919

casey opened this issue Aug 29, 2024 · 2 comments · Fixed by #3968

Comments

@casey
Copy link
Collaborator

casey commented Aug 29, 2024

For example:

https://ordinals.com/output/0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef:123

This is because the JSON RPC status code / message for output not found was changed, so we don't correctly transform it into a 404 not found HTTP error.

@cryptoni9n
Copy link
Collaborator

When reproduced in the env terminal I see this error:

error serving request: JSON-RPC error: RPC error response: RpcError { code: -5, message: "No such mempool or blockchain transaction. Use gettransaction for wallet transactions.", data: None }

I hope this information will help in getting to the bottom of it. I looked into the code and wasn't able to get very far in fixing it.

@raphjaph
Copy link
Collaborator

I think this might fix it: #3968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants