Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collecting and trading tracking issue #581

Closed
25 of 26 tasks
raphjaph opened this issue Sep 29, 2022 · 3 comments
Closed
25 of 26 tasks

Collecting and trading tracking issue #581

raphjaph opened this issue Sep 29, 2022 · 3 comments
Assignees

Comments

@raphjaph
Copy link
Collaborator

raphjaph commented Sep 29, 2022

  • ord wallet identify: show any rare ordinals in wallet
  • ord wallet list: list all ordinal ranges in contained in utxos controlled by bitcoincore wallet
  • ord wallet send ORDINAL ADDRESS: send ORDINAL to ADDRESS
    • send whole UTXO that contains ORDINAL to ADDRESS
    • test that transaction building fails if ordinal isn't sent to address
    • add should_panic tests for final checks
    • rename Template to TransactionBuilder
    • Template::build_transaction -> TransactionBuilder::build
    • move to own module
    • test template to transaction conversion
    • convert final tests to test transaction that is produced, not template
    • pay fee
    • Strip after ordinal if UTXO is larger than POSTAGE * 2, add change output to reduce POSTAGE to 1 x POSTAGE
    • Align ordinal to beginning of sent output
    • if ordinal would be lost in fee range, add input
    • if utxo is insufficient to pay fee, add input
    • if first output is below dust limit, add input
    • check that no dust outputs are created
    • display a good error message if we don't have enough padding inputs
    • add invariant that each change address appears at most once in outputs
    • add invariant that recipient address appears exactly once in outputs
    • refuse to send if other rare ordinals would also be sent to recipient or be consumed by fee
    • improve fee estimation
    • allow mainnet if wallet is named ord- and balances are low #692
    • manually test with bitcoin core #688
    • release a new version to github and crates.io #691
@raphjaph raphjaph self-assigned this Sep 30, 2022
@casey casey changed the title Wallet tracking issue Wallet MVP tracking issue Oct 6, 2022
@casey casey changed the title Wallet MVP tracking issue Collecting and trading MVP tracking issue Oct 6, 2022
@casey casey changed the title Collecting and trading MVP tracking issue Collecting and trading tracking issue Oct 6, 2022
@casey
Copy link
Collaborator

casey commented Oct 13, 2022

@raphjaph I just added a bunch of things that I had in a notes file. After the PR that we have in flight now, I think that almost all of these can be done in small follow-up PRs.

@casey
Copy link
Collaborator

casey commented Oct 20, 2022

I partially implemented refusing to send rare ordinals in #680. However, we still need to check that the utxo that we're sending doesn't contain any rare ordinals aside from the one we're sending. (If the user explicitly sends a rare ordinal, then we should assume they know what they're doing.)

@casey
Copy link
Collaborator

casey commented Oct 21, 2022

Closing in favor of individual issues. Nice work!

@casey casey closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants