pnpm v8

[zkochan]

This is a discussion about pnpm v8 breaking changes.

• make auto-install-peers=true the default. Looks like this is what most people expect since npm has made this the default behavior.
• make save-workspace-protocol=rolling the default.
• make publishConfig.linkDirectory true by default
• make resolution-mode=time-based the default (too early). But we can start installing the lowest version of direct dependencies.
• - resolve-peers-from-workspace-root is true by default
• remove the registry fields from the lockfile
• Improve how directory names are shortened. Change .substring(0, 50) in this line to .substring(0, 120 - 26 - 1)
• set dedupeDirectDeps to true by default in @pnpm/core.
• resolution-mode is lowest-direct by default.
• dedupe-peer-dependents should be true by default.
• Drop Node.js 14 support
• Drop support of lockfile v5. Lockfile v5 should be converted to lockfile v6 automatically on pnpm install

[mcmxcdev]

Not pnpm related per se, but dropping Node v14 + v17 from GitHub Actions and adopting Node 18 (which soon is LTS) should be part of pnpm v8 release.

[mcmxcdev]

Related to pnpm config, we tend to set --ignore-workspace-root-checkto false and --engine-strict to true for each project in .npmrc. Might be worth discussing.

[zkochan]

Regarding Node.js v14 support, it depends on when pnpm v8 will be shipped.

Accidentally installing a package in the root is a frequent mistake, so I am not in favor of allowing it by default.

[hiepxanh]

add pn as alias for pnpm for faster typing <3

[EscapeB]

Change the behavior of shared-workspace-lockfile=false

Not like the old behavior by setting shared-workspace-lockfile=false, which will have multiple virtual store.

The new expected behavior is we still using the shared virtual store but have individual lock file for each package in pnpm worksapces.

[mark-omarov]

[zkochan]

It is probably possible but I don't see how it is related to v8 release. Just create a new issue.

[zkochan]

I am locking this for contributors only because for some reason people started to make feature requests here.

[mcmxcdev]

We use use-inline-specifiers-lockfile-format=true since its release in https://github.com/pnpm/pnpm/releases/tag/v7.7.0 and really like it. Having potentially less merge conflicts is a good thing and this could be a contender to be enabled by default in v8.

[zkochan]

I think there are some more changes to the lockfile format that we would want to ship.

[mcmxcdev]

@zkochan I just noticed that there are still older issues flagged with breaking change around, might make sense to work on them for v8:
https://github.com/pnpm/pnpm/issues?q=is%3Aopen+is%3Aissue+label%3A%22type%3A+breaking+change%22+sort%3Aupdated-desc

[zkochan]

This one would be good to do #3054

about the other one I don't care.

[iobuhov]

Is there a plan to create migration guide on how to migrate project from 7 to 8?

[zkochan]

I am not sure what migration guide would be needed. I think the release page is clear enough: https://github.com/pnpm/pnpm/releases/tag/v8.0.0-rc.0

[iobuhov]

Okay

[dipunm]

Hey all, I am trying to get my head around one specific feature: resolve-peers-from-workspace-root.

From the documentation, I understood it to mean that if any peer dependencies are listed for any dependency of a package, and if the workspace root has that peer dependency installed, then it should indirectly install that peer dependency for the package.

Looking at the node_modules this does not seem to happen.

I thought I may have misinterpreted it to mean that if you install the peer dependency, then pnpm will look to the workspace root in order to resolve the correct version number. This is indeed the case, but it seems to work with or without the setting, and with or without typescript being listed as a peer dependency.

Another thing I tested was peer dependency version conflicts. If I declare typescript@~5.1.0 as my peer dependency and install [email protected] in the workspace root, I expect to see some version mismatching warnings.

At this point, I don't think I understand what this feature provides. Can someone help me to understand?

Here is my project layout btw for context:

- [root]
  - devDependencies:
    - typescript
  - packages: 
    - ts-config
      - peerDependencies:
        - typescript
    - projectA
      - devDependencies:
        - ts-config