feature: parallel should support limit Infinity and OnlyPositiveNumbers

[MarlonPassos-git]

Problem:

Currently, when we pass Infinite it throws an error

import * as _ from 'radashi'

const [errors, results] = await _.try(async () => {
  return _.parallel(Infinity, _.list(1, 3), async (num) => {
    await _.sleep(2000)

    return `hi_${num}`
  })
})()

console.log(errors, results)

It's easy to fix it with.

const queues = list(1, Math.min(limit, array.length)).map(() => new Promise(processor));

This can also be good because if the person passes a value in parallels that is greater than the size of the array, we don't create unnecessary things.

but testing this I ended up realizing that if I pass 0 or a negative number it doesn't work either.

import * as _ from 'radashi'

const [errors, results] = await _.try(async () => {
  return _.parallel(-100, _.list(1, 3), async (num) => {
    await _.sleep(2000)

    return `hi_${num}`
  })
})()

console.log(errors, results)

I think it would be interesting to deal with this case, in the code we could validate that the number has to be greater than 0

if (limit < 1)  {
  Throw new Error ("Only positive numbers are allowed.")
}

and on the typescript side I think we could use this type to enforce positive values with this type

type PositiveInteger<T extends number> =
  `${T}` extends '0' | `-${any}` | `${any}.${any}` ? NegativeNumber : T

However, in this case, I have doubts whether this would be a major change. 🤔

Related Issues

sodiray/radash#426

[aleclarson]

Definitely agree on Infinity.

I'd be fine with clamping anything less than 1 to be equal to 1.

[MarlonPassos-git]

ok i wiil work on it. About the type PositiveInteger, what do you whink ?

[aleclarson]

It's a cool idea, but we should wait on it until we can give a better type-level error message (tracked by this TypeScript issue). Besides, it's unlikely that anyone will type 0 or a negative number in there, IMO.

[MarlonPassos-git]

#238