What about having a banner? #1397
Replies: 13 comments
-
I have put together a package for the purpose: node-banner |
Beta Was this translation helpful? Give feedback.
-
cc: @verdaccio/collaborators @verdaccio/core-team If you link https://opencollective.com/verdaccio at the end with a nice message saying encouraging people to donate or contribute, I'm in. But look pretty nice. Let's see what others think. |
Beta Was this translation helpful? Give feedback.
-
btw, what did you use to achieve that ? :-) |
Beta Was this translation helpful? Give feedback.
-
I think there are already some banner plugins. I'm not a big fan of such FIGlet solutions in general. Generally we can hardcode it using a template string + kleur (or one of the FIGlet implementations). |
Beta Was this translation helpful? Give feedback.
-
We already use kleur and adding the (optional) banner can be easily achieved. I don't think that we need another package which may reference a different kleur version. Let's reuse and directly integrate it. @juanpicado figlet and kleur (see the dependencies tab of https://npmjs.com/node-banner). |
Beta Was this translation helpful? Give feedback.
-
I think @DanielRuf is right. Less dependencies, less headache. |
Beta Was this translation helpful? Give feedback.
-
Since this is irrelevant as per now shall we close this 🤔 |
Beta Was this translation helpful? Give feedback.
-
I think you misunderstood the feedback, it's fine, but should be "home made" rather using a dependency. Using a template or something is an option, but within our source code, easy to change or update, does it make sense for you? |
Beta Was this translation helpful? Give feedback.
-
Actually, I'd reuse the header. Something like to have a future |
Beta Was this translation helpful? Give feedback.
-
@jamesgeorge007 are you still on this? |
Beta Was this translation helpful? Give feedback.
-
I'm out of town, will shoot up a PR soon
…On Sat, 27 Jul 2019, 09:13 Juan Picado @jotadeveloper, < ***@***.***> wrote:
@jamesgeorge007 <https://github.com/jamesgeorge007> are you still on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/verdaccio/verdaccio/issues/1397?email_source=notifications&email_token=AGA3WH7EO3ONBQ7C5TJQ3HDQBO77BA5CNFSM4IFJ6SXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD26CZGI#issuecomment-515648665>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGA3WHZ6NTE2WEAB25SJWKLQBO77BANCNFSM4IFJ6SXA>
.
|
Beta Was this translation helpful? Give feedback.
-
I'm not that sure on how to give it a kick-start (as what you guys intend). |
Beta Was this translation helpful? Give feedback.
-
@jamesgeorge007 just use imagination, but I'd recommend do not add new dependencies and if you have to, then should be hosted in our monorepo. |
Beta Was this translation helpful? Give feedback.
-
Output of
verdaccio --info
Beta Was this translation helpful? Give feedback.
All reactions