Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check type 2 AppImages #1

Closed
probonopd opened this issue Oct 6, 2016 · 2 comments
Closed

Check type 2 AppImages #1

probonopd opened this issue Oct 6, 2016 · 2 comments

Comments

@probonopd
Copy link

https://github.com/AppImage/AppImageSpec/blob/master/draft.md#type-2-image-format

Experimental implementation:
https://github.com/probonopd/appimagetool

The advantage of this is that there is no fixed offset for the filesystem image, which means that it is not so tightly size-restricted.

@orivej
Copy link
Owner

orivej commented Nov 14, 2016

Thanks for referring me to the spec!

It's neat how you solved the loss of application icons in squashfs images and automated chmod +x with appimaged.

Why did you keep chdir($mnt/usr) in the spec and in AppRun? What applications benefit from this?

@probonopd
Copy link
Author

probonopd commented Nov 14, 2016

Some applications and libraries hardcode paths in /usr. This is why for these, we binary patch the absolute path /usr to the relative path ././ which works if we cd to $APPDIR/usr before executing the app, and if the app does not call chrdir().

There are more elegant ways around this, but so far none of them seems to work 100% yet. Contributions in this area are highly welcome.

@orivej orivej closed this as completed Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants