You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #3722 we disabled WriteRead*MissingPerformGets` tests since they were disabled before this big refactoring but after running clang-format they got re-enabled as the gtest TEST_F does not work if its expanded in a multi-line invocation as it was before this PR. This needs to be resolved.
Enabling these tests results errors when BP5 is used.
Yeah, these tests need to be refactored before they'll work with BP5 as they rely upon BP4 behaviour that we explicitly deprecated. Commenting out for now is fine and I'll clean up after this is merged. (There are probably more tests that got disabled at some point and should be re-enabled, so a broader look might be useful.)
In #3722 we disabled WriteRead*MissingPerformGets` tests since they were disabled before this big refactoring but after running clang-format they got re-enabled as the gtest TEST_F does not work if its expanded in a multi-line invocation as it was before this PR. This needs to be resolved.
Enabling these tests results errors when BP5 is used.
Originally posted by @vicentebolea in #3722 (comment)
The text was updated successfully, but these errors were encountered: