From e4417b242185650fd324e97d5605ac6dfcacc9b1 Mon Sep 17 00:00:00 2001 From: Oliver Kurz Date: Wed, 20 Dec 2023 14:25:39 +0100 Subject: [PATCH] t: Use consistent 'Mojo::Base' instead of strict+warnings Same as suggested in our documentation we should use Mojo::Base consistently in all openQA test modules. --- lib/utils.pm | 1 - tests/containers/build.pm | 3 +-- tests/install/boot.pm | 3 +-- tests/install/openqa_webui.pm | 3 +-- tests/install/openqa_worker.pm | 3 +-- tests/install/test_distribution.pm | 3 +-- tests/openQA/dashboard.pm | 3 +-- tests/openQA/login.pm | 3 +-- tests/osautoinst/start_test.pm | 3 +-- tests/osautoinst/test_running.pm | 1 - tests/osautoinst/worker.pm | 3 +-- tests/shutdown/shutdown.pm | 3 +-- 12 files changed, 10 insertions(+), 22 deletions(-) diff --git a/lib/utils.pm b/lib/utils.pm index ff7ee123..1bcbfb55 100644 --- a/lib/utils.pm +++ b/lib/utils.pm @@ -2,7 +2,6 @@ package utils; use Mojo::Base 'Exporter', -signatures; use Exporter; -use strict; use testapi; use File::Basename qw(basename); diff --git a/tests/containers/build.pm b/tests/containers/build.pm index da5c551c..875f5e12 100644 --- a/tests/containers/build.pm +++ b/tests/containers/build.pm @@ -1,5 +1,4 @@ -use strict; -use base 'openQAcoretest'; +use Mojo::Base 'openQAcoretest'; use testapi; sub run { diff --git a/tests/install/boot.pm b/tests/install/boot.pm index 97d1408e..5bc3c85c 100644 --- a/tests/install/boot.pm +++ b/tests/install/boot.pm @@ -1,5 +1,4 @@ -use strict; -use base 'openQAcoretest'; +use Mojo::Base 'openQAcoretest'; use utils; sub run { diff --git a/tests/install/openqa_webui.pm b/tests/install/openqa_webui.pm index 266820d6..b52b003d 100644 --- a/tests/install/openqa_webui.pm +++ b/tests/install/openqa_webui.pm @@ -1,5 +1,4 @@ -use strict; -use base 'openQAcoretest'; +use Mojo::Base 'openQAcoretest'; use testapi; use utils; diff --git a/tests/install/openqa_worker.pm b/tests/install/openqa_worker.pm index 89ce0f87..66337f5f 100644 --- a/tests/install/openqa_worker.pm +++ b/tests/install/openqa_worker.pm @@ -1,5 +1,4 @@ -use strict; -use base 'openQAcoretest'; +use Mojo::Base 'openQAcoretest'; use testapi; use utils; diff --git a/tests/install/test_distribution.pm b/tests/install/test_distribution.pm index 936c58c7..10feb7f4 100644 --- a/tests/install/test_distribution.pm +++ b/tests/install/test_distribution.pm @@ -1,5 +1,4 @@ -use strict; -use base 'openQAcoretest'; +use Mojo::Base 'openQAcoretest'; use testapi; use utils; diff --git a/tests/openQA/dashboard.pm b/tests/openQA/dashboard.pm index 3a9cf121..13bb0dd9 100644 --- a/tests/openQA/dashboard.pm +++ b/tests/openQA/dashboard.pm @@ -1,5 +1,4 @@ -use strict; -use base 'openQAcoretest'; +use Mojo::Base 'openQAcoretest'; use testapi; use utils; diff --git a/tests/openQA/login.pm b/tests/openQA/login.pm index 7cfd470e..9a2de9a3 100644 --- a/tests/openQA/login.pm +++ b/tests/openQA/login.pm @@ -1,5 +1,4 @@ -use strict; -use base 'openQAcoretest'; +use Mojo::Base 'openQAcoretest'; use testapi; sub run { diff --git a/tests/osautoinst/start_test.pm b/tests/osautoinst/start_test.pm index 0e3cad05..aa36b9aa 100644 --- a/tests/osautoinst/start_test.pm +++ b/tests/osautoinst/start_test.pm @@ -1,5 +1,4 @@ -use strict; -use base 'openQAcoretest'; +use Mojo::Base 'openQAcoretest'; use testapi; use utils; diff --git a/tests/osautoinst/test_running.pm b/tests/osautoinst/test_running.pm index 962058ab..6ecfc984 100644 --- a/tests/osautoinst/test_running.pm +++ b/tests/osautoinst/test_running.pm @@ -1,4 +1,3 @@ -use strict; use Mojo::Base 'openQAcoretest', -signatures; use testapi; use utils; diff --git a/tests/osautoinst/worker.pm b/tests/osautoinst/worker.pm index 2c1d53a9..b78ac37a 100644 --- a/tests/osautoinst/worker.pm +++ b/tests/osautoinst/worker.pm @@ -1,5 +1,4 @@ -use strict; -use base 'openQAcoretest'; +use Mojo::Base 'openQAcoretest'; use testapi; use utils qw(wait_for_desktop switch_to_root_console clear_root_console); diff --git a/tests/shutdown/shutdown.pm b/tests/shutdown/shutdown.pm index b3feabb8..1f3ef95a 100644 --- a/tests/shutdown/shutdown.pm +++ b/tests/shutdown/shutdown.pm @@ -1,5 +1,4 @@ -use strict; -use base 'openQAcoretest'; +use Mojo::Base 'openQAcoretest'; use testapi; use utils qw(switch_to_root_console);