Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pipfile-requirements manager from .thoth.yaml #207

Closed
Tracked by #401
shreekarSS opened this issue Sep 16, 2022 · 1 comment · Fixed by #212
Closed
Tracked by #401

Remove pipfile-requirements manager from .thoth.yaml #207

shreekarSS opened this issue Sep 16, 2022 · 1 comment · Fixed by #212
Labels
bug Something isn't working

Comments

@shreekarSS
Copy link
Contributor

shreekarSS commented Sep 16, 2022

Describe the bug

The pipfile-requirements manager can be removed because requirements.txt isn’t being utilized for packaging or deployment. Only the Pipfile.lock is needed for deployment info.
Else Kebechet's Update manager will not work on this aicoe-osc-demo repo

To Reproduce
Steps to reproduce the behavior:

  1. Create an issue with title 'Kebechet update'
  2. Kebechet's pipfile-requirements manager will fail with creating new issue like No pinned version for src shreekarSS/aicoe-osc-demo#2

Expected behavior
Once Update manager runs successfully, it will raise a PR like shreekarSS#3

@codificat
Copy link
Member

Actually, the pipfile-requirements manager failure like shreekarSS#2 might be a bug in Kebechet, as I believe that the mentioned Pipfile entry could be translated to a requirements.txt entry.

Nevertherless, it's probably a good idea to remove that manager from this repo's configuration, as you say, because there is no requirements.txt here and it doesn't seem to be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants