1342: replace foreach with reduce

os2display · May 28, 2024 · f82c3b4 · f82c3b4
1 parent de565e4
commit f82c3b4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 13 deletions.
diff --git a/build/travel-config-develop.json b/build/travel-config-develop.json
@@ -4,8 +4,8 @@
   "id": "01FZD7K807VAKZ99BGSSCHRJM6",
   "description": "Skabelon til rejseplanen.",
   "resources": {
-    "component": "https://raw.githubusercontent.com/os2display/display-templates/develop/build/travel.js?ts=1716556232231",
-    "admin": "https://raw.githubusercontent.com/os2display/display-templates/develop/build/travel-admin.json?ts=1716556232231",
+    "component": "https://raw.githubusercontent.com/os2display/display-templates/develop/build/travel.js?ts=1716881579494",
+    "admin": "https://raw.githubusercontent.com/os2display/display-templates/develop/build/travel-admin.json?ts=1716881579494",
     "schema": "",
     "assets": [],
     "options": {},

diff --git a/build/travel-config-main.json b/build/travel-config-main.json
@@ -4,8 +4,8 @@
   "id": "01FZD7K807VAKZ99BGSSCHRJM6",
   "description": "Skabelon til rejseplanen.",
   "resources": {
-    "component": "https://raw.githubusercontent.com/os2display/display-templates/main/build/travel.js?ts=1716556232231",
-    "admin": "https://raw.githubusercontent.com/os2display/display-templates/main/build/travel-admin.json?ts=1716556232231",
+    "component": "https://raw.githubusercontent.com/os2display/display-templates/main/build/travel.js?ts=1716881579494",
+    "admin": "https://raw.githubusercontent.com/os2display/display-templates/main/build/travel-admin.json?ts=1716881579494",
     "schema": "",
     "assets": [],
     "options": {},

diff --git a/build/travel.js b/build/travel.js
diff --git a/src/travel/travel.js b/src/travel/travel.js
@@ -51,14 +51,7 @@ function Travel({ slide, content, run, slideDone, executionId }) {
       return "";
     }
 
-    let ids = "";
-    if (station && station.length > 0) {
-      // To create this string: "id@id@id@"
-      station.forEach(({ id }) => {
-        ids += `${id}@`;
-      });
-    }
-    return ids;
+    return station.reduce((carry, { id }) => `${carry}${id}@`, "");
   };
 
   const imageStyle = {};