Feature/1342 update rejseplans template to remove hack yay #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
tuj
requested changes
May 27, 2024
src/travel/travel.js
Outdated
| // After meeting*s* about this, we have concluded that the ids follow a pattern, where the last character | ||
| // in the string is defining which direction, and can be anything from 0-9. | ||
| // So, here we replace the last character of the id with 0-9, and then the rejseplan-api disregards ids that | ||
| // are not connected to a station (we hope). | ||
| const getStationIds = () => { | ||
| if (!(station instanceof Array) || station.length === 0) { | ||
| return ""; | ||
| } | ||
|
|
||
| let ids = ""; |
There was a problem hiding this comment.
Replace all below with:
Suggested change
| let ids = ""; | |
| return station.reduce((carry, {id}) => `${carry}${id}@`, ''); |
The if (!station) is handled above...
tuj
approved these changes
May 28, 2024
sinejespersen
deleted the
feature/1342-update-rejseplans-template-to-remove-hack-yay
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/#/tickets/showTicket/1342
I replaced the current solution ("hack") with a solution where all the ids from the station-array are added to the url for the iframe. this means, that the admin has a multiselect, and the stations the user wants to be displayed can now be displayed. This was made possible because Rejseplanen updated their api.
This works with data from the new api, and data from the old - it does not break anything per se. That being said, when we are removing the existing hack, the current templates will only show a bus/tram in one direction, not both directions. The people with installations this affects will be notified.