Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ar 853 video mute #82

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Conversation

sinejespersen
Copy link
Contributor

https://jira.itkdev.dk/browse/AR-854

Mute is default, possible to choose video has sound and then it is not muted. this might mean that it wont play, if the configuration is wrong, but this is stated in a help text

@sinejespersen sinejespersen requested a review from tuj August 29, 2022 11:28
if (sound) {
videoRef.current.muted = false;
}
console.log(videoRef.current.muted);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console.log

@sinejespersen sinejespersen merged commit ffb546a into develop Aug 30, 2022
@sinejespersen sinejespersen deleted the feature/AR-853-video-mute branch August 30, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants