Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to setting /ignore and /notify by default? #118

Closed
whoizit opened this issue Jan 18, 2019 · 7 comments · Fixed by #344
Closed

how to setting /ignore and /notify by default? #118

whoizit opened this issue Jan 18, 2019 · 7 comments · Fixed by #344

Comments

@whoizit
Copy link

whoizit commented Jan 18, 2019

subject

@osa1
Copy link
Owner

osa1 commented Jan 19, 2019

This was mentioned a few times in some other tickets -- we currently doesn't support this.

Ideally I think we need a few things:

  • A way to set default values of these. E.g. in the config file:

    defaults:
      ignore: true # enable ignore by default
      notify: off # disable notifications my default
    
  • A way to set these parameters when joining, e.g.

    /join #foo -ignore -notify all
    

    This should join #foo with "ignore" on and "notify" set to "all".

  • The parameters above should work in config file too, e.g.

    join:
      - '#tiny -ignore -notify all'
    

Not to hard to implement but I just need to allocate a few hours.

If anyone wants to contribute let me know and I can help.

@maddiemort
Copy link

Unless someone else is working on this, I think I'll take a crack at it, starting tonight, along with #217.

@osa1
Copy link
Owner

osa1 commented Oct 1, 2020

@nerosnm go for it! Let me know if you have any questions.

@osa1 osa1 added this to the v1.0 milestone Dec 16, 2020
@trevarj
Copy link
Contributor

trevarj commented Dec 17, 2020

@nerosnm anything on this? 😬

@osa1
Copy link
Owner

osa1 commented Dec 17, 2020

@trevarj it's been more than 2 months without any updates, I think this is up for grabs.

@maddiemort
Copy link

maddiemort commented Dec 17, 2020

Hi, really sorry about that! This kind of slipped off my radar, I ended up not really having the bandwidth to work on it. Anyone else please feel free to take it over.

@osa1
Copy link
Owner

osa1 commented Dec 17, 2020

No problem @nerosnm , thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants