Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash in getproperty for GAPFuncsType #122

Closed
fingolfin opened this issue Nov 2, 2018 · 1 comment
Closed

crash in getproperty for GAPFuncsType #122

fingolfin opened this issue Nov 2, 2018 · 1 comment
Labels
kind: bug Something isn't working

Comments

@fingolfin
Copy link
Member

Asking for GAP.GAPFuncs.TRANSDEGREES segfaults, because TRANSDEGREES is an immediate integer, but our code does

    variable = ccall(:GAP_ValueGlobalVariable,MPtr,(Ptr{UInt8},),name_string)

so it expects an MPtr. Return type should instead be a union of MPtr, GapFFE, Int64.

Even with that fixed, that code should still also check that what it got is a function.
@fingolfin fingolfin added the kind: bug Something isn't working label Nov 2, 2018
@sebasguts
Copy link
Contributor

Resolved in #139 by @fingolfin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fingolfin @sebasguts