-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GAP Error shows up in Julia tests, but does not lead to failure (happens on Travis) #235
Comments
The error message is printed by GAP. Thus it is correct that the tests are regarded as successful. The point seems to be to change the handling of GAP's error messages |
Indeed. The error message there is intentional, and its appearance is right :) |
Of course the error is intentional, but I disagree that its appearance in this place is right. Rather, this is a bug: GAP prints its error message directly to the terminal, which it should not. I am not sure what should happen, but not this. |
I guess the underlying issue here is that ideally want to integrate the IO subsystems of GAP and Julia more closely, so that they don't interfere with each other as much. That's of course non-trivial work, and also it's not 100% clear what this means. Perhaps that GAP uses Julia IO functions (so ultimately: |
This was resolved by PR #355 |
The following is seen in a successful (!) Travis build
We should fix this error; also I am kind of worried that it doesn't lead to a test failure; perhaps we should first improve our setup to ensure it does fail the Travis test, before actually fixing it.
The text was updated successfully, but these errors were encountered: