Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more and systematic tests for all features #30

Open
fingolfin opened this issue Sep 18, 2018 · 2 comments
Open

Add more and systematic tests for all features #30

fingolfin opened this issue Sep 18, 2018 · 2 comments
Labels
help wanted Extra attention is needed kind: enhancement New feature or request topic: tests CI coverage

Comments

@fingolfin
Copy link
Member

fingolfin commented Sep 18, 2018 •
edited
Loading

My dream would be if TDD (test driven development) was used. In the meantime, it would be great to increase our coverage, see https://codecov.io/gh/oscar-system/GAP.jl. Looking at it, there is a lot of code that is never exercised.
@fingolfin fingolfin added kind: enhancement New feature or request help wanted Extra attention is needed labels Nov 1, 2018
@fingolfin

This comment has been minimized.

Sign in to view
@fingolfin
Copy link
Member Author

We already made quite some progress since I wrote this, but are still far from 100% coverage. We probably won't ever get there, as some code paths are there for paranoia only and thus should never be triggered. But there are already 122 uncovered lines in the src dir, see https://codecov.io/gh/oscar-system/GAP.jl/tree/master/src . Some of these will require addressing issue #460.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed kind: enhancement New feature or request topic: tests CI coverage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fingolfin