Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit GAP.GAPFuncs #67

Closed
fingolfin opened this issue Oct 11, 2018 · 1 comment
Closed

Revisit GAP.GAPFuncs #67

fingolfin opened this issue Oct 11, 2018 · 1 comment

Comments

@fingolfin
Copy link
Member

Right now, all GAP library level functions are automatically exported to Julia as GAP.GAPFuncs when the JuliaInterface package is loaded.

There are some issues with that, though: AddGapJuliaFuncs is only called once at the start, so any GAP functions added later on are not exported to Julia. This can be solved by calling the (currently undocumented) function AddGapJuliaFuncs. But I note that this takes ~700 milliseconds on my laptop, which isn't so nice (also in general, as it delays start up).

Perhaps GAP.GAPFuncs could be implemented in a fashion similar to what we now do for the Julia object on the GAP side, i.e., GAP.GAPFuncs.foo is looked up dynamically.

Alternatively, having a GAP.WrapGAPFunc function (in addition to or instead of GAP.GAPFuncs) and then writing e.g. MyFunc = GAP.WrapGAPFunc("MyFunc") in .jl files doesn't sounds so bad to me either.

@fingolfin
Copy link
Member Author

This was resolved by PR #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant