Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better automatic Singular banner hiding #611

Closed
fingolfin opened this issue Nov 15, 2022 · 1 comment · Fixed by #668
Closed

Better automatic Singular banner hiding #611

fingolfin opened this issue Nov 15, 2022 · 1 comment · Fixed by #668

Comments

@fingolfin
Copy link
Member

fingolfin commented Nov 15, 2022

My students are writing a package which depends on Oscar. Loading their package in Julia 1.8.2 shows the Oscar banner, but also the Singular and Polymake banners. We have logic in place which is supposed to prevent this. Perhaps it needs to be update in a similar fashion to what @thofma did in oscar-system/GAP.jl#826 ?

(Perhaps we should move this logic into a helper function and put it into a helper package that is then used by GAP.jl, Singular.jl, Polymake.jl -- this way we only need to update this and a few other things in only one place? Or even without the package, if there was an identical helper function used in all three packages, updating it would be easier).

See also oscar-system/Polymake.jl#412

@fingolfin
Copy link
Member Author

Resolved by PR #668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant