Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI option not to prepend v to versions #43

Open
MrVauxs opened this issue Jul 20, 2024 · 7 comments
Open

Add CLI option not to prepend v to versions #43

MrVauxs opened this issue Jul 20, 2024 · 7 comments

Comments

@MrVauxs
Copy link
Contributor

MrVauxs commented Jul 20, 2024

As title says, preferably in the CLI. It is quite annoying to an otherwise excellent npm script to just run at the end of everything.
Code_oz8Xo7pkHW

@MrVauxs
Copy link
Contributor Author

MrVauxs commented Jul 21, 2024

This seems to be the offending code.

return `v${release.version}`;

@MrVauxs MrVauxs changed the title Option not to prepend v to versions Add option not to prepend v to versions Jul 21, 2024
@MrVauxs MrVauxs changed the title Add option not to prepend v to versions Add CLI option not to prepend v to versions Jul 21, 2024
@MrVauxs MrVauxs mentioned this issue Jul 21, 2024
@oscarotero
Copy link
Owner

It's a good practice to prepend the git tags of the releases with v.
Anyway, there's already a tagNameBuilder option to customize the tag name.

@MrVauxs
Copy link
Contributor Author

MrVauxs commented Jul 21, 2024

It's a good practice to prepend the git tags of the releases with v.

A practice, but not a semver version. And if something relies on tags as the version then it'll break with the pretended v.

Anyway, there's already a tagNameBuilder option to customize the tag name.

TagNameBuilder is only available if you build a JS script. For such a small change in functionality I'd rather not have to create an entire script file for it.

@oscarotero
Copy link
Owner

Okay, but instead of creating a new option in the Changelog class, I think it's better to simply provide a cli option to use a different tagNameBuilder. For example:

changelog --no-v-prefix

@MrVauxs
Copy link
Contributor Author

MrVauxs commented Jul 21, 2024

I have modified the related PR with the suggestion.

@oscarotero
Copy link
Owner

Merged. Thanks!

@oscarotero
Copy link
Owner

I can't publish the NPM package due this bug denoland/dnt#421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants