Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Command System #12

Closed
Brendonovich opened this issue Feb 21, 2023 · 2 comments
Closed

New Command System #12

Brendonovich opened this issue Feb 21, 2023 · 2 comments

Comments

@Brendonovich
Copy link
Collaborator

Tauri will be retiring the macro-based command system at some point
tauri-apps/tauri#3256

@Brendonovich
Copy link
Collaborator Author

This poses a significant problem compared to the current approach, and the only solutions I can think of are:

  1. We provides a wrapper around the command builder that is specta-aware,
  2. We require specifying commands a second time in either a macro or function like happens now, or
  3. This is retired and becomes the specta feature of Tauri, which brings its own challenges in enforcing conditional trait requirements since cmd_* should only require SpectaFunction if the specta feature is enabled.

If approach 3 is taken then Tauri would need to conditionally compile multiple versions of cmd_* (which could result in a combinatoric explosion if more features were added to Tauri) or use proc macros to generate different implementations of cmd_* based on what features are enabled.

Alternatively we could just not support the new command system and push people to use rspc, Tauri will be building basically the same thing - only thing missing from rspc is one time commands.

@oscartbeaumont
Copy link
Member

oscartbeaumont commented Apr 30, 2024

I'm closing this because Tauri are getting close to release and I don't think this is happening anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants