Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace signup with direct channel link #120

Merged
merged 6 commits into from
Apr 26, 2018
Merged

Conversation

gplv2
Copy link
Contributor

@gplv2 gplv2 commented Apr 26, 2018

we talked about this in the community and think this is a better and more direct link to our channel and will pass signup automatically when the user has no account yet.

@@ -7,7 +7,6 @@
"name": "OpenStreetMap BE Riot channel",
"description": "All mappers are welcome! Sign up at {signupUrl}",
Copy link
Contributor

@jbelien jbelien Apr 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove signupUrl you also should remove Sign up at {signupUrl} from here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, tx for feedback

@bhousel
Copy link
Member

bhousel commented Apr 26, 2018

Thank you!

@bhousel bhousel merged commit 9a219e0 into osmlab:master Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants