Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning of youthmappers.svg #285

Merged
merged 2 commits into from
Oct 19, 2019
Merged

Cleaning of youthmappers.svg #285

merged 2 commits into from
Oct 19, 2019

Conversation

jbelien
Copy link
Contributor

@jbelien jbelien commented Oct 18, 2019

I'm not sure why the file is in both dist/img/ (where it should be with all the others) and svg/ ...

@bhousel
Copy link
Member

bhousel commented Oct 18, 2019

The svg/youthmappers.svg can probably go away.
It doesn't look like you changed anything in these commits - what were you trying to do?

@jbelien
Copy link
Contributor Author

jbelien commented Oct 18, 2019

I removed the unnecessary <?xml version="1.0" encoding="UTF-8"?>
But more important, I also removed the width="385px" height="385px" ; it messes up any proper use of the SVG.

@bhousel
Copy link
Member

bhousel commented Oct 19, 2019

oh ok!

@bhousel bhousel merged commit d76a8a6 into osmlab:master Oct 19, 2019
bhousel added a commit that referenced this pull request Oct 19, 2019
@bhousel
Remove extra youthmappers.svg
b15786c 
(re: #285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbelien @bhousel