Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the northern extent of the scotland polygon #297

Closed
wants to merge 1 commit into from
Closed

Adjust the northern extent of the scotland polygon #297

wants to merge 1 commit into from

Conversation

gravitystorm
Copy link
Contributor

It previously extended too far north and included the Faroe Islands.

I haven't recalculated the area, but the contributing guide suggests this will be calculated automatically.

It previously extended too far north and included the Faroe Islands
@bhousel
Copy link
Member

bhousel commented Nov 15, 2019

Thanks!

  • Yes area will be calculated automatically on build...
  • I'm working on Depend on country-coder #291 right now which will let us depend on a new library called country-coder ..
    (hat tip to @quincylvania 🎩)
  • I took a look at their data, and it seems like they already have the Scottish boundary not including the Faroe Islands
  • So I'm going to close this since it will be fixed in a few days anyway, and there's no point in generating a merge conflict in a file that will be going away 😆

@bhousel bhousel closed this Nov 15, 2019
@gravitystorm
Copy link
Contributor Author

gravitystorm commented Nov 15, 2019

So I'm going to close this since it will be fixed in a few days anyway, and there's no point in generating a merge conflict in a file that will be going away

Fair enough!

@gravitystorm gravitystorm deleted the patch-1 branch November 15, 2019 09:24
@bhousel
Copy link
Member

bhousel commented Nov 15, 2019

ok haha.. Funny story..
It turns out Scotland doesn't have their own ISO country code, so we do need this .geojson file to stay around after all because sub-country regions are not supported in country-coder yet. So I'll be taking this PR after all haha.

@bhousel
Copy link
Member

bhousel commented Nov 15, 2019

Since you deleted the branch, I'm just going to do the same thing over on my branch 😆

bhousel added a commit that referenced this pull request Nov 15, 2019
This snaps it to the points that country-coder uses for the UK boundary
(re: #297)
@gravitystorm
Copy link
Contributor Author

Since you deleted the branch, I'm just going to do the same thing over on my branch laughing

Sorry for the hassle! The boundary in your branch looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants