Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Serbian community resources #404

Merged
merged 1 commit into from
Jan 3, 2021
Merged

Adding Serbian community resources #404

merged 1 commit into from
Jan 3, 2021

Conversation

stalker314314
Copy link
Contributor

Initial addition of all things I can collect about Serbian projects. Note that we keep programming resources under Gitlab, and I added them under "github" type (since there were no "gitlab" type and I though that generic "osm" type will not do the justice).

@bhousel
Copy link
Member

bhousel commented Jan 2, 2021

since there were no "gitlab" type and I though that generic "osm" type will not do the justice

We could add a gitlab type - FontAwesome supports it: https://fontawesome.com/icons?d=gallery&q=gitlab&s=brands

@stalker314314
Copy link
Contributor Author

Or maybe you could broaden definition of "github" type. Rename it to "git" (everything related to git, including github, gitlab etc.) with git icon (because git != github :D). Or, if you don't want to stop with git, rename it to "sources", such that it represent collection of source codes for a given community (but, I cannot find appropriate FontAwesome icon for it).

(I am just throwing ideas, any approach is fine by me!)

@bhousel
Copy link
Member

bhousel commented Jan 3, 2021

The purpose of the type is to match it to a reasonable icon, so I'll just add a gitlab one.

I don't think things like github and gitlab are really the kinds of "communities" that you want to push onto people who are just casuallly editing around Serbia, but if you want to do that we support it.

@bhousel bhousel merged commit b028acc into osmlab:main Jan 3, 2021
bhousel added a commit that referenced this pull request Jan 3, 2021
@stalker314314
Copy link
Contributor Author

No, didn't want to push anything to people (especially explaining them why github != git) 😄 . But, I guess approach with "gitlab" type (as you did it) makes sense (otherwise osm-community-index wouldn't have matrix, telegram, irc... as types, you would have only one named "messaging" 😄 ). At least this is how I rationalized it to myself:) Anyway, thanks for very quick response and addition!

jbelien added a commit to jbelien/oci-viewer that referenced this pull request Jan 5, 2021
@jbelien
Copy link
Contributor

jbelien commented Jan 5, 2021

GitLab resources have been added to https://community.osm.be/ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants