Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match Design Guidelines and Headless Components #1148

Closed
6 of 14 tasks
JoseRFelix opened this issue Dec 16, 2022 · 2 comments
Closed
6 of 14 tasks

Match Design Guidelines and Headless Components #1148

JoseRFelix opened this issue Dec 16, 2022 · 2 comments
Assignees

Comments

@JoseRFelix
Copy link
Collaborator

JoseRFelix commented Dec 16, 2022

Problem

As the app grows we must start relying on design guidelines to maintain consistent styling and user experience. Further, components must be customizable, and accessible for screen readers and keyboard users.

Proposed Solution

We must start creating components that adhere to our design guidelines and maintain accessibility throughout the app. Since we use Tailwind CSS, it makes sense to use headless components like Headless UI and Radix that integrate beautifully and are accessible. Furthermore, following modern practices standardized by libraries like Material UI and Chakra UI, we'll use the library CVA to build components with variants to avoid the arduous task of class matching.

I've identified the following components that must be migrated/integrated:

Button

Popover

Modal

  • New Pool
  • Deposit
  • Withdraw
  • Connect Wallet

Input

Select

  • Deposit (Network select)

Drawer

Icons

@JoseRFelix JoseRFelix self-assigned this Dec 16, 2022
@JoseRFelix JoseRFelix changed the title Headless Components Headless Components and match Design Guidelines Dec 16, 2022
@JoseRFelix JoseRFelix changed the title Headless Components and match Design Guidelines Match Design Guidelines and Headless Components Dec 16, 2022
@syed8rahman
Copy link

Adjust Swap settings to match Figma UI https://www.figma.com/file/om93lu8iXOhxwGHSUpAXEP/Trade-UI?node-id=93%3A1765&t=3ZhgpLpgcHzq2Pia-1
Screen Shot 2022-12-16 at 11 55 56 AM

@jonator
Copy link
Member

jonator commented Apr 28, 2023

Closing in favor of tracking on ClickUp

@jonator jonator closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants