Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL][bug] Update reward splitting logic to only use bonded balancer amounts #5192

Closed
AlpinYukseloglu opened this issue May 16, 2023 · 0 comments · Fixed by #5239
Closed

[CL][bug] Update reward splitting logic to only use bonded balancer amounts #5192

AlpinYukseloglu opened this issue May 16, 2023 · 0 comments · Fixed by #5239
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@AlpinYukseloglu
Copy link
Contributor

Background

Our current reward splitting implementation seems to use the full balancer liquidity amount to calculate how much to split off. Even though these rewards all go to the bonded tokens (since they're routed through the gauge), this is still unintended behavior and we should be using the bonded amounts if possible.

Suggested Design

  • Update reward splitting logic to only use bonded balancer amounts

Acceptance Criteria

  • New functionality is tested & new and existing tests pass
@AlpinYukseloglu AlpinYukseloglu added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label May 16, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development May 16, 2023
@AlpinYukseloglu AlpinYukseloglu mentioned this issue May 19, 2023
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CL][bugfix] Update reward splitting logic to only use bonded balancer amounts osmosis-labs/osmosis
1 participant
@AlpinYukseloglu