Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import paths github action #5391

Closed
pysel opened this issue Jun 1, 2023 · 7 comments
Closed

Fix import paths github action #5391

pysel opened this issue Jun 1, 2023 · 7 comments
Assignees
Labels

Comments

@pysel
Copy link
Member

pysel commented Jun 1, 2023

Background

The import paths workflow seems broken:
https://github.com/osmosis-labs/osmosis/actions/runs/5115321530

Acceptance

The workflow works when manually running it

@pysel pysel added the T:dev-UX label Jun 1, 2023
@pysel pysel self-assigned this Jun 1, 2023
@pysel
Copy link
Member Author

pysel commented Jun 2, 2023

#5401 fixes the logic for getting the version_to_replace variable

there is another issue with this workflow:

the workflow will still fail, because after updating import paths to (for example) v16 from v15, some recently introduced modules will have an invalid version set. Ex:

How go.mod of cl-go-client looks after workflow run (from v15 to v16):

github.com/osmosis-labs/osmosis/v16 v15.0.0-20230530235412-9f091596cbcf

error it results in is:

version "v15.0.0-20230530235412-9f091596cbcf" invalid: should be v16, not v15

Here is how this error looks in gh actions.

Question to reviewers:
Are we running this workflow after the release is created or before? In former case, it would be easy to simply change the version of github.com/osmosis-labs/osmosis/vX in modules that import it

@p0mvn
Copy link
Member

p0mvn commented Jun 2, 2023

Before

@p0mvn
Copy link
Member

p0mvn commented Jun 2, 2023

@pysel thanks for the timely update of this script! Do you think you could also auto-apply state compatibility and changelog labels to the PR created by this CI job?

@p0mvn
Copy link
Member

p0mvn commented Jun 2, 2023

Also, FYI, the proto-gen CI check is failing: https://github.com/osmosis-labs/osmosis/actions/runs/5159223921/jobs/9293878347?pr=5408

ref: #5408

@p0mvn
Copy link
Member

p0mvn commented Jun 2, 2023

The script doesn't seem to run make proto-all at the end, can we fix that?

@pysel
Copy link
Member Author

pysel commented Jun 3, 2023

the logic for proto has not been changed, but it only runs proto-gen, w/o formatting them

@pysel
Copy link
Member Author

pysel commented Jul 16, 2023

Closing as resolved

@pysel pysel closed this as completed Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants