Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VS Incentives]: Update queries to handle group gauges #6154

Closed
Tracked by #6057
AlpinYukseloglu opened this issue Aug 25, 2023 · 0 comments · Fixed by #6594 or #6604
Closed
Tracked by #6057

[VS Incentives]: Update queries to handle group gauges #6154

AlpinYukseloglu opened this issue Aug 25, 2023 · 0 comments · Fixed by #6594 or #6604
Assignees
Labels
F: volume-splitting feat: Volume-splitting incentives

Comments

@AlpinYukseloglu
Copy link
Contributor

AlpinYukseloglu commented Aug 25, 2023

Background

Since group gauges utilize the pool's internal perpetual gauge, is internal/external incentive queries to accommodate the fact that external incentives might route through the pool's internal gauges. This might be slightly hairy to do depending on what the flow we need to accommodate is.

Note on the decision to route through internal gauges: the original design of having external gauges create completely independent gauges unfortunately introduces some complications when gauges distribute to many gauges/pools. We could potentially create a second set of internal gauges to simplify query complexity, but we would need to go back and create these for all existing pools in upgrade handler.

Suggested Design

List of queries to implement:

  • all groups
  • all group gauges
  • all 1:1 mapped groups and group gauges packaged together
  • group by group gauge ID
  • volume for a given pool

Confirm that the following continue to function correctly:

  • /osmosis/pool-incentives/v1beta1/external_incentive_gauges
  • /osmosis/pool-incentives/v1beta1/incentivized_pools
  • /osmosis/pool-incentives/v1beta1/distr_info
  • /osmosis/pool-incentives/v1beta1/gauge-ids/${poolId}
  • osmosis/incentives/v1beta1/gauges

Acceptance Criteria

  • Frontend's query needs are met
  • Old queries hold their invariants
  • New queries implemented
@AlpinYukseloglu AlpinYukseloglu added the F: volume-splitting feat: Volume-splitting incentives label Aug 25, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Aug 25, 2023
@czarcas7ic czarcas7ic self-assigned this Sep 26, 2023
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Sep 29, 2023
@czarcas7ic czarcas7ic reopened this Sep 29, 2023
@github-project-automation github-project-automation bot moved this from Done ✅ to In Progress🏃 in Osmosis Chain Development Sep 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress🏃 to Done ✅ in Osmosis Chain Development Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: volume-splitting feat: Volume-splitting incentives
Projects
Archived in project
2 participants