Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VS Incentives]: more CreateGroup and Distribute test cases #6559

Closed
5 tasks
Tracked by #6057
p0mvn opened this issue Sep 27, 2023 · 0 comments · Fixed by #6599
Closed
5 tasks
Tracked by #6057

[VS Incentives]: more CreateGroup and Distribute test cases #6559

p0mvn opened this issue Sep 27, 2023 · 0 comments · Fixed by #6599
Assignees
Labels
F: volume-splitting feat: Volume-splitting incentives T:tests

Comments

@p0mvn
Copy link
Member

p0mvn commented Sep 27, 2023

We need more CreateGroup and Distribute test cases

Namely:

  • Test_Distribute_Group_OverlappingPoolsInGroups - two groups, distribute to the same gauges, assert distributions are as expected
  • Test_Distribute_Group_NoVolumeOnePool_SkipSilent - two groups, one has no volume, assert that it is silently skipped but other distributes
  • Test_Distribute_Group_ChangeVolumeBetween - two groups distribute over 2 epochs, volume changed between epochs
  • Test_Distribute_Group_CreateGroupsBetween - start with one group at epoch, add another group at second epoch
  • Test_Distribute_Group_SwapAndDistribute - update volume by swapping instead of setting state directly and then distribute

Originally posted by @p0mvn in #6548 (comment)

A/C

  • All tests are added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: volume-splitting feat: Volume-splitting incentives T:tests
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant