Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoolAccountInvariant stops for-zero-height export #833

Closed
HathorNodes opened this issue Feb 9, 2022 · 2 comments · Fixed by #1198
Closed

PoolAccountInvariant stops for-zero-height export #833

HathorNodes opened this issue Feb 9, 2022 · 2 comments · Fixed by #1198

Comments

@HathorNodes
Copy link

HathorNodes commented Feb 9, 2022

When using osmosisd export --for-zero-height --height=-1 the PoolAccountInvariant is trigged causing this error:

panic: invariant broken: gamm: pool-account-balance-equals-expected invariant
    gamm pool id 1
    asset coins: 4300015858680ibc/27394FB092D2ECCD56123C74F36E4C1F926001CEADA9CA97EA622B25F41E5EB2,22352934610113uosmo
    account coins: 4300015858680ibc/27394FB092D2ECCD56123C74F36E4C1F926001CEADA9CA97EA622B25F41E5EB2,1000000000ibc/9989AD6CCA39D1131523DB0617B50F6442081162294B4795E26746292467B525,22352934610113uosmo


    CRITICAL please submit the following transaction:
         tx crisis invariant-broken gamm pool-account-balance-equals-expected

This is caused become somebody sent a LIKE coin to Pool #1 as well as Pool #555 (though that pool isn't even checked at this point). This causes the balance of pool's wallets to not match the assets of the pool.

See balance of pool #1 here:
https://www.mintscan.io/osmosis/account/osmo1mw0ac6rwlp5r8wapwk3zs6g29h8fcscxqakdzw9emkne6c8wjp9q0t3v8t

The transaction still shows too. Same person sent 1 LIKE to pool #555. Not really sure how to address the issue, I can still use pool 555 to swap.

Screen Shot 2022-02-08 at 8 40 24 PM

Despite having LIKE as an asset pool 555 doesn't include the "extra" LIKE to its assetes balance.

The TX suggested submitting the invariant-broken to halt the chain, but that seemed excessive so I figured I'd post it here first!

@HathorNodes
Copy link
Author

@czarcas7ic

@ValarDragon
Copy link
Member

ValarDragon commented Feb 11, 2022

Yeah, we need to change the invariant. The invariant itself is bad.

Also plz don't submit that crisis tx to the chain, you'll just lose funds. The chain won't actually do anything with that crisis tx atm

Repository owner moved this from 🔍 Needs Review to ✅ Done in Osmosis Chain Development Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants