Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webifying breaks with model names with space in them #193

Closed
konduri opened this issue Sep 3, 2020 · 2 comments
Closed

Webifying breaks with model names with space in them #193

konduri opened this issue Sep 3, 2020 · 2 comments

Comments

@konduri
Copy link

konduri commented Sep 3, 2020

Trying to webify a model call "floor_Living room"with following model.sdf breaks during webifying. The model comes up without any issue in gzclient.

<?xml version='1.0' encoding='us-ascii'?>
<sdf version="1.6">
  <model name="floor_Living room">
    <static>true</static>
    <link name="link">
      <collision name="collision">
        <pose>0 0 0 0 0 0</pose>
        <geometry>
          <mesh>
            <uri>model://generation_j592zpc9lvyz_world_1/floor_Living room/meshes/floor_Living room.dae</uri>
            <scale>1 1 1</scale>
          </mesh>
        </geometry>
      </collision>
      <visual name="visual">
        <meta>
          <layer>0</layer>
        </meta>
        <pose>0 0 0 0 0 0</pose>
        <geometry>
          <mesh>
            <uri>model://generation_j592zpc9lvyz_world_1/floor_Living room/meshes/floor_Living room.dae</uri>
            <scale>1 1 1</scale>
          </mesh>
        </geometry>
      </visual>
    </link>
  </model>
</sdf>

When webifying the above model, we encounter the following error. It appears that when parsing through the models, gzweb doesnt handle model names with spaces in them. "floor_living room" is considered as "room" and breaks the webification.

Specifically this line: https://github.com/osrf/gzweb/blob/master/webify_models_v2.py#L65
error_webify

@chapulina
Copy link
Contributor

I think you may find many other issues trying to use spaces within names on Gazebo-classic. My recommendation is not to have spaces so you can avoid other problems. Here are some related issues:

(for reference, we have good support for names with spaces on Ignition)

@chapulina
Copy link
Contributor

This issue seems to be a duplicate of #160. I'll close this one and keep the conversation there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants