Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion and general opinion on the actual needs #10

Closed
jrutgeer opened this issue Mar 24, 2023 · 3 comments
Closed

Suggestion and general opinion on the actual needs #10

jrutgeer opened this issue Mar 24, 2023 · 3 comments

Comments

@jrutgeer
Copy link

Suggestion:

1. Show the existence of ROS 2 [tutorials](https://docs.ros.org/en/humble/Tutorials.html) (2 mins)

The tutorials are nice, but show only a very limited subset of the functionality. So I suggest to also mention the demos and examples repositories.


On a more general note:

What I think is really really missing, both for ROS 2 as well as gazebo, is a general overview of the code base:
in depth descriptions of how the code is structured, which concepts are used, why, how, etc.
I.e. basic info that helps you understand the code.

This is an excellent example: WaitSet Presentation at RTWG. It provides all the info you need to understand and use the code, yet it is concise and to the point. (Note that this video can only be found through this github issue; afaik it is not part of, nor referenced by any official documentation, although it is very valuable.)

Same goes for gazebo. An example: as a layman try to debug why the conveyor demo is not working. So far, I tracked it down to the contact plugin missing in the sdf, but then also this entitycast failing. So now I have to try and understand the reason for that. Without any background info on what an entityWorldMap is, how it is populated, etc., this utterly utterly time consuming. Most people just give up and file an issue instead.


So even though this is probably (imo. falsely) considered out of scope for the icra tutorial, I think it would be far more valuable to the community, than yet another getting started session.

My two cents...

@jrutgeer
Copy link
Author

So far, I tracked it down to the contact plugin missing in the sdf, but then also this entitycast failing.

Turns out the contact plugin is not needed after all.
The simulation features are defined here and here.
So the conclusion is clear: it simply needs a more recent version of libdart.

But apart from that: I still don't understand how exactly above feature definitions relate to the entitycast. Though I am sure that it's no rocket science...

If ROS 2 / gazebo wants to welcome more user contributions for core functionality, then it is essential that this kind of information is better explained.

@clalancette
Copy link
Collaborator

The tutorials are nice, but show only a very limited subset of the functionality. So I suggest to also mention the demos and examples repositories.

Yes, that is a great idea. We won't add it to the outline that is here, but we'll make sure to add it to the slides.

What I think is really really missing, both for ROS 2 as well as gazebo, is a general overview of the code base:
in depth descriptions of how the code is structured, which concepts are used, why, how, etc.
I.e. basic info that helps you understand the code.

Yes, we agree that would be valuable. However, the target audience for this tutorial isn't people who are working deeply in the core, but rather people who want to use ROS 2 (and are coming from ROS 1), or Gazebo (and are coming from Gazebo Classic). So while we will include e.g. a plugin walkthrough in Gazebo (which will cover the essential concepts), we will not be going into depth on these topics.

@mabelzhang
Copy link
Collaborator

Closing as no new activity for a month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants