Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate testPitchAndDepthMassVBS.xml with our CI #99

Closed
arjo129 opened this issue Nov 30, 2021 · 0 comments · Fixed by #105
Closed

Integrate testPitchAndDepthMassVBS.xml with our CI #99

arjo129 opened this issue Nov 30, 2021 · 0 comments · Fixed by #105

Comments

@arjo129
Copy link
Member

arjo129 commented Nov 30, 2021

Currently we test all the missions except for testPitchAndDepthMassVBS.xml, but we should also integrate the testPitchAndDepthMassVBS.xml with our CI.

@arjo129 arjo129 changed the title Integrate testPitchAndDepthMassVBS.xml Integrate testPitchAndDepthMassVBS.xml with our CI Nov 30, 2021
arjo129 added a commit that referenced this issue Dec 1, 2021

Verified

This commit was signed with the committer’s verified signature. The key has expired.
pocke Masataka Pocke Kuwabara
Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 linked a pull request Dec 1, 2021 that will close this issue
arjo129 added a commit that referenced this issue Dec 2, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Address #99 . Integrates PitchMass VBS test

Signed-off-by: Arjo Chakravarty <[email protected]>

* Add mission pitch and depth control

Signed-off-by: Arjo Chakravarty <[email protected]>

* Add some reasonable assertions

Signed-off-by: Arjo Chakravarty <[email protected]>

* temp stash

Signed-off-by: Arjo Chakravarty <[email protected]>

* change assertions to expectations. Set REALLY big uncertainties to be narrowed down.

Signed-off-by: Arjo Chakravarty <[email protected]>

* update comment

Signed-off-by: Arjo Chakravarty <[email protected]>

* better comments

Signed-off-by: Arjo Chakravarty <[email protected]>

* comments +docs

Signed-off-by: Arjo Chakravarty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant