-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find python3 in cmake, fix warning #328
Conversation
Signed-off-by: Steve Peters <[email protected]>
The sdformat ci is still failing one test, which seems psutil related:
|
Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf9 #328 +/- ##
=======================================
Coverage 86.40% 86.40%
=======================================
Files 59 59
Lines 9053 9053
=======================================
Hits 7822 7822
Misses 1231 1231 Continue to review full report at Codecov.
|
should be fixed by 1f84744 |
CI is 🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I guess CMake warnings are ignored in windows?
I guess not; it actually has quite a few cmake warnings, but we'll just leave those alone for now |
Signed-off-by: Steve Peters <[email protected]>
* Also use python3 in test Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
* Also use python3 in test Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
* Also use python3 in test Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
* Also use python3 in test Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
* Also use python3 in test Signed-off-by: Steve Peters <[email protected]>
* Also use python3 in test Signed-off-by: Steve Peters <[email protected]>
* Also use python3 in test Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
* Also use python3 in test Signed-off-by: Steve Peters <[email protected]>
* Fix cmake warning about newlines * Find python3 in cmake, fix warning (#328) Signed-off-by: Steve Peters <[email protected]>
There are some cmake warnings now reported by jenkins since we upgraded one of the jenkins plugins:
The issue is that we are installing the python3 version of
psutil
, so we need to find thepython3
interpreter in cmake.