Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define PATH_MAX for Debian Hurd system #369

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Define PATH_MAX for Debian Hurd system #369

merged 1 commit into from
Sep 9, 2020

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Sep 8, 2020

The Hurd operativy system does not fully follow the POSIX standard and does not define the PATH_MAX variable, see bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892231. I just following how other projects patched this by defining if it does not exists.

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Sep 8, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2020

Codecov Report

Merging #369 into sdf9 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             sdf9     #369   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files          59       59           
  Lines        9177     9177           
=======================================
  Hits         7917     7917           
  Misses       1260     1260           
Impacted Files Coverage Δ
src/Filesystem.cc 98.80% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e27010b...2ef2452. Read the comment docs.

@scpeters scpeters merged commit 7819366 into sdf9 Sep 9, 2020
@scpeters scpeters deleted the path_max_hurd branch September 9, 2020 17:14
@scpeters
Copy link
Member

scpeters commented Sep 9, 2020

do you need this in a 9.3.1?

@j-rivero
Copy link
Contributor Author

j-rivero commented Sep 9, 2020

do you need this in a 9.3.1?

It can wait, I've included these changes in Debian latest version. thanks

scpeters pushed a commit to scpeters/sdformat that referenced this pull request Sep 9, 2020
scpeters pushed a commit that referenced this pull request Sep 10, 2020
azeey pushed a commit to azeey/sdformat that referenced this pull request Dec 9, 2020
brawner pushed a commit that referenced this pull request Dec 11, 2020
brawner pushed a commit that referenced this pull request Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants