Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JointAxis: remove UseParentModelFrame methods #379

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

scpeters
Copy link
Member

These methods were deprecated in libsdformat9, so remove them from libsdformat10.

These methods were deprecated in libsdformat9, so remove
them from libsdformat10.

Signed-off-by: Steve Peters <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #379 into sdf10 will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            sdf10     #379      +/-   ##
==========================================
+ Coverage   87.33%   87.37%   +0.04%     
==========================================
  Files          60       60              
  Lines        9220     9215       -5     
==========================================
  Hits         8052     8052              
+ Misses       1168     1163       -5     
Impacted Files Coverage Δ
src/JointAxis.cc 97.31% <ø> (+3.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4eb5d...099160d. Read the comment docs.

@scpeters
Copy link
Member Author

abi checker failed, but that's ok because this hasn't been released yet

Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@scpeters scpeters merged commit bc8f413 into gazebosim:sdf10 Sep 29, 2020
@scpeters scpeters deleted the rm_deprecated_10 branch September 29, 2020 23:56
azeey pushed a commit to azeey/sdformat that referenced this pull request Dec 9, 2020
These methods were deprecated in libsdformat9, so remove
them from libsdformat10.

Signed-off-by: Steve Peters <[email protected]>
brawner pushed a commit that referenced this pull request Dec 11, 2020
These methods were deprecated in libsdformat9, so remove
them from libsdformat10.

Signed-off-by: Steve Peters <[email protected]>
brawner pushed a commit that referenced this pull request Jan 9, 2021
These methods were deprecated in libsdformat9, so remove
them from libsdformat10.

Signed-off-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants