Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease far clip lower bound #435

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Decrease far clip lower bound #435

merged 1 commit into from
Dec 14, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Dec 11, 2020

A far clip plane for a camera can be less than 10m. I'm setting the minimum value to match the value for the depth_camera.

Signed-off-by: Nate Koenig [email protected]

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from iche033 December 11, 2020 22:09
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Dec 11, 2020
@nkoenig
Copy link
Contributor Author

nkoenig commented Dec 14, 2020

The test failures look unrelated to this change.

@nkoenig nkoenig merged commit 9995007 into sdf9 Dec 14, 2020
@nkoenig nkoenig deleted the lower_far_clip_min branch December 14, 2020 22:08
nkoenig pushed a commit that referenced this pull request Dec 14, 2020
scpeters pushed a commit to scpeters/sdformat that referenced this pull request Dec 15, 2020
Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
scpeters pushed a commit that referenced this pull request Dec 15, 2020
scpeters pushed a commit to scpeters/sdformat that referenced this pull request May 17, 2021
* added to sdf 1.7 in gazebosim#435

Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
scpeters added a commit that referenced this pull request May 19, 2021
* sdf 1.8: Add <double_sided> to material from #410
* sdf 1.8: Add lightmap to 1.8 spec from #429
* sdf 1.8: document Add L16 camera pixel format from #487

Signed-off-by: Ian Chen <[email protected]>

* sdf 1.8: Decrease far clip lower bound from #435

Signed-off-by: Nate Koenig <[email protected]>

* sdf 1.8: Added render_order to material from #446

Signed-off-by: ahcorde <[email protected]>

* sdf 1.8: Add camera type aliases to docs. from #514
* sdf 1.8: Improve docs of collision_bitmask from #521

Signed-off-by: Martin Pecka <[email protected]>

* sdf 1.8: support nested models in @attached_to from #316

Signed-off-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants