Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods for removing attributes from an element #555

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

jennuine
Copy link
Collaborator

Signed-off-by: Jenn Nguyen [email protected]

🎉 New feature

Summary

Added methods:

  • sdf::Element::RemoveAttribute(string key): Removes a specified attribute from the Element
  • sdf::Element::RemoveAllAttributes(): Removes all attributes from the Element

This should be forward ported to sdf10 and sdf11.

Test it

./build/sdformat9/src/UNIT_Element_TEST --gtest_filter=Element.RemoveAttribute
./build/sdformat9/src/UNIT_Element_TEST --gtest_filter=Element.RemoveAllAttributes

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Code check passed (In source directory, run sh tools/code_check.sh)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review
    another open pull request
    to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@jennuine jennuine merged commit 9858c22 into sdf9 Apr 29, 2021
@jennuine jennuine deleted the jennuine/remove_attr branch April 29, 2021 20:09
@scpeters scpeters mentioned this pull request May 17, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants