Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Data Formatting #181

Open
zohaib-a-ahmed opened this issue May 6, 2024 · 16 comments · Fixed by #183 or #184
Open

Updated Data Formatting #181

zohaib-a-ahmed opened this issue May 6, 2024 · 16 comments · Fixed by #183 or #184
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@zohaib-a-ahmed
Copy link
Collaborator

Clients introduced a new data format that MeltShiny is going to operate from named as AYGU-1_MeltR that should be used going forward.

This will require rewriting some buried architecture regarding formatting the data going into the MeltR package, which is currently throwing internal errors (within MeltR package). Something is incorrectly being passed into the library post data upload.

This bug needs to be addressed before the application can be used with the new csv format.

@zohaib-a-ahmed zohaib-a-ahmed added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels May 6, 2024
@adhampton110
Copy link
Collaborator

adhampton110 commented May 30, 2024

/cc @zohaib-a-ahmed @Massi-Papi @ethan-gray-01 @LikhitaPulijala @BollepalliPranitha @kungfuchicken

It appears there are two options going forward. Does the end user wish to pursue either of these options:

  1. Support for both formats: old (test.csv) & new (AYGU-1_MeltR.csv)
  2. Support for the New Format Only: (AYGU-1_MeltR.csv)

@adhampton110
Copy link
Collaborator

For testing purposes, when using AYGU-1_MeltR.csv as the dataset file, what should be the values for the following fields?:

  • Sample number of blank
  • Select the wavelength
  • Enter the temperature used to calculate the concentration with Beers law
  • Specify necelic acid type
  • Specify sequences
  • Decide if you wan to have the molar extinction coefficients calculated or provide them manually
  • Optional methods
  • Choose a Tm method
  • Select the molecular state

@adhampton110
Copy link
Collaborator

@BollepalliPranitha Did you merge #183 by accident?

@BollepalliPranitha
Copy link
Collaborator

@adhampton110
I merged the PR and thought of creating the new issue for the bug . But I found that the issue found is working with test.csv, so I reverted back the changes .
so those changes were not in the main
You can work on the bug and make the necessary changes

@BollepalliPranitha BollepalliPranitha removed the good first issue Good for newcomers label Sep 7, 2024
@adhampton110
Copy link
Collaborator

adhampton110 commented Sep 7, 2024

For testing purposes, when using AYGU-1_MeltR.csv as the dataset file, what should be the values for the following fields?:

  • Sample number of blank
  • Select the wavelength
  • Enter the temperature used to calculate the concentration with Beers law
  • Specify nucleic acid type
  • Specify sequences
  • Decide if you wan to have the molar extinction coefficients calculated or provide them manually
  • Optional methods
  • Choose a Tm method
  • Select the molecular state

Could we get confirmation on the suggested inputs for this testing file from the clients?

@BollepalliPranitha
Copy link
Collaborator

@adhampton110 Can you test for these sequences .
AYGU-1_MeltR.csv
BLYA-1.1_MeltR.csv
IH-1_MeltR-260.csv

AYGU-1_MeltR.csv
Sample 1
No Blanks
Wavelength – 260
Nucleic acid type – RNA
Sequence – GACUAGUU
Molecular state - Homoduplex

Sample 2
BLYA-1.1_MeltR.csv
No Blanks
Wavelength – 260
Nucleic acid type – RNA
Sequence – CCACGUCUCG,CGAGAGUGG
Molecular state - Heteroduplex

Sample 3
IH-1_MeltR-260.csv
No Blanks
Wavelength – 260
Nucleic acid type – RNA
Sequence - GGCGUIAUAGCC
Molecular state - Monomolecular

I have provided data for monomolecular, heteroduplex, and homoduplex samples.
The format of the data is similar in all the three files
So we need to test against these values

@adhampton110
Copy link
Collaborator

@BollepalliPranitha

I had successful uploads with Sample 1 & Sample 2. I ran into this error message using Sample 3. Taking a look at the MeltR source code, I am hitting this error.
Screenshot 2024-09-07 at 1 31 58 PM

I am wondering if we are to specify the coefficients, as opposed to specifying the sequence
Screenshot 2024-09-07 at 1 52 02 PM

@BollepalliPranitha
Copy link
Collaborator

@adhampton110
could you please send me all the values you used for this format of data
I think the sequence specified is an issue.
Will update you regarding the sequence.

@adhampton110
Copy link
Collaborator

adhampton110 commented Sep 7, 2024

@BollepalliPranitha

Here are the raw inputs I am passing directly into the meltR.A function. masterFrame is the IH-1_MeltR-260.csv file, as a data frame object:
Screenshot 2024-09-07 at 6 30 13 PM

@BollepalliPranitha
Copy link
Collaborator

@adhampton110 Have you tried using any other sequence for Monomolecular
because I cant find the "I" included in the code
image
Try for other sequences
I don't think Monomolecular option is working for any sequences .

@adhampton110
Copy link
Collaborator

@BollepalliPranitha I have not, which is why I have been attempting to interact with the MeltR package directly within the R console. With the specified inputs you gave me, if we aren't able to create a meltR.A object when directly interacting with the package, then we also are not going to be able to create a meltR.A object with our application code. Our app code just calls the meltR.A function.

@BollepalliPranitha
Copy link
Collaborator

@adhampton110
for sample 3 , can you try with sequence "GGCGUGAUAGCC"
This is suggested by client
image

@adhampton110
Copy link
Collaborator

adhampton110 commented Sep 11, 2024

@BollepalliPranitha I am unable to reproduce their successful creation. Have you attempted to create the meltR.A object with the inputs from the screenshot?

The screenshot contains a syntax error, around the fitTs parameter, to which I believe the value would be set to NULL but the methods parameter would be set to c(TRUE, TRUE, TRUE). Is this the full screenshot?

@adhampton110
Copy link
Collaborator

Screenshot 2024-09-10 at 8 32 59 PM

This is exactly what I am inputting into the meltR.A function. Please let me know if my inputs are incorrect.

@BollepalliPranitha
Copy link
Collaborator

@adhampton110 I think there are so many outliers present in the data provided that should be manually handled. I am in discussing this with client. The issue persists with the data and Sequence.

@BollepalliPranitha
Copy link
Collaborator

BollepalliPranitha commented Sep 14, 2024

This issue is related to the newly created issue #185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Status: In Progress
3 participants